search

larsch / ocra

One-Click Ruby Application Builder
http://ocra.rubyforge.org/
833 stars 84 forks source link

bug fixing: extension.so and gen.build_complete #100

Closed jcangas closed 8 years ago

jcangas commented 9 years ago

Using ruby 2.1.6p336 and ocra-1.3.5 with inno setup option: 1) ocra add extension.so to the ocratemp.iss, but he file enumerator.so is not instaled by ruby 2.1.6 (not in my entire disk). Otra defined const IGNORE_MODULES already contains enumerador.so, but seems this constant is ignore when innosetup option is used.

2) I'm using psych-2.0.13, a gem with native extensions. Ocra detect and include it in the inno setup installer. When I run the installed project psych-2.0.13 it complaints about the gem native extension not builded. The problem is the file gem.build_complete is missing in extensions folder: ocra must add this file to ocratemp.iss if present when orca detect a gem.

This pull request fix both problems

larsch commented 8 years ago

Cherry-picked a95b6ff. Other issue was resolved by #97.

jcangas commented 8 years ago

I just tried ocra 1.3.6 and it still complaint with the "enumerator.so" problem when building my iss script.

jcangas commented 8 years ago

But using the last version bin/ocra in master works fine. So, we need another fresh release :)