larsenwork / monoid

Customisable coding font with alternates, ligatures and contextual positioning. Crazy crisp at 12px/9pt. http://larsenwork.com/monoid/
7.85k stars 170 forks source link

Period ligature bug #112

Open fnky opened 8 years ago

fnky commented 8 years ago

When typing more than 3 periods, it will show whitespace and a single ellipsis.

Text
"   .           ..          ...       ........"
    ^           ^           ^         ^
full stop   double-dot   ellipsis    ellipsis followed
                                     by five full-stops
Xcode
dots
Atom
atom
Sketch
sk

Note: Currently only tested with the Retina version.

larsenwork commented 8 years ago

what version are you running? should be fixed.

fnky commented 8 years ago

I updated to 0.60 and there's still issues with the periods. Take the following text

... .. .......... .. . ..d
atom

As you can see, this even happens without ligatures enabled.

larsenwork commented 8 years ago

what happens? .. and ... are closer by design similar to || and soon !! since they denote a single "function" and end up too close the surrounding characters if they weren't squeezed a bit.

............... used to have bug that would make it look like 
            ... but that should have been fixed
fnky commented 8 years ago

Yes the example you gave is fixed in 0.60. I understand that they're closer, that is the ligature feature. But note the double period follow by d (..d). This shows whitespace between the dots (. .d).

As you can see in my screenshot, this happens to both, no matter wether ligatures is on or off.

larsenwork commented 8 years ago

screen shot 2015-08-08 at 22 07 52

I haven't been able to reproduce that - not sure what's going on. :/

fnky commented 8 years ago

Actually I tested it in atom, so it's a problem in Atom, which I know isn't supported. But somehow it changed the behavior from the above to this:

atom

The cursor is simply a bug in Atom, not counting size of ligatures, not a bug in the font.

larsenwork commented 8 years ago

https://github.com/larsenwork/monoid/issues/112#issuecomment-129042037 I'm also using atom

fnky commented 8 years ago

This is the stylesheet I used

{
  -webkit-font-feature-settings: "liga" on, "calt" on;
}

atom-text-editor::shadow {
  .cursor-line {
    -webkit-font-feature-settings: "liga" off, "calt" off;
  }
}

It disables ligatures on current selected line.

larsenwork commented 8 years ago

I know - it's what I'm using too :) And Atom works just fine for me (Monoid - not Monoisome)

Why is the last dot and the d orange? Maybe it's your syntax highlighting that's affecting it somehow...

fnky commented 8 years ago

Yep, it was using SCSS syntax highlighting. If there's syntax highlighting it will act as the above screenshot. However, if there isn't, the cursor will not be positioned according to the position in buffer.

14px

multi

12px

multi12

I haven't cut in the screenshot of the Plain Text, that was actually how it look with the cutoff d. And all cursors were at the end of line.

This is tested with a generated font Monoid HalfLoose. I have yet to test other variations.