Permits to have duplicate column names

larsga / Duke

Duke is a fast and flexible deduplication engine written in Java

Apache License 2.0

614 stars 194 forks source link

Permits to have duplicate column names #204

Closed programaths closed 8 years ago

programaths commented 9 years ago

Permits configurations like :

        <column property="Champ1" name="Champ1" />
        <column property="NomSoundex" name="Champ1"/>
        <column property="Champ2" name="Champ2"/>
        <column property="PrenomSoundex" name="Champ2"/>
        <column property="Champ7" name="Champ7"/>
        <column property="Champ28" name="Champ28"/>
        <column property="Champ5" name="Champ5" />

Otherwise, gave a "outOfBoundException".

larsga commented 8 years ago

Not being able to support references to the same column more than once is definitely an issue, but this patch deletes two blocks of code for no obvious reason, and doesn't compile. So there's no way I can accept this pull request. Sorry. If you rework it a bit I'd be happy include it.

larsga commented 8 years ago

I see now that this is basically an earlier version of pull request #206, and that pull request seems to fix the problems with this one. So closing this one as presumably abandoned by the author.