search

larsga / Duke

Duke is a fast and flexible deduplication engine written in Java
Apache License 2.0
613 stars 194 forks source link

added stopwords cleaner with tests #228

Open shivam5992 opened 7 years ago

larsga commented 7 years ago

This is an interesting addition! For applications that match text this looks very useful. Thank you.

The build fails with a compile error: /home/travis/build/larsga/Duke/duke-core/src/main/java/no/priv/garshol/duke/cleaners/StopwordsCleaner.java:[49,21] error: cannot find symbol

Looks like you're using a newer Java version. Please fix that.

Also, please remove the .idea folder from the PR.

I'll go through the code and comment on that now.

shivam5992 commented 7 years ago

Okay, I will update this.

larsga commented 7 years ago

Thank you! That's much appreciated. I hope you agree with the comments. If not, just let me know.

shivam5992 commented 7 years ago

Larsga,

I have updated every point except for -

  1. .idea folder
  2. the test case which you mentioned.

Thanks