larsgw / censordle

Guess Wikipedia article titles based on the censored contents of their articles
https://larsgw.github.io/censordle/
MIT License
2 stars 2 forks source link

Potential fix for #10 #12

Closed hexylena closed 1 year ago

hexylena commented 1 year ago

It's maybe not the most aesthetic solution but here is one option. Another in https://github.com/larsgw/censordle/pull/13

Screenshot 2023-07-01 at 10-35-07 Censordle

bencomp commented 1 year ago

Thanks! I haven't tested it on an iPhone, but I think this is a good solution that fixes #10.

Did you see if with this extra letter spacing for censored words there is more text rearranging across lines as words are guessed and 'uncovered'? I noticed that it happens already, depending on the actual contents.

hexylena commented 1 year ago

I strongly suspect it leads to more layout shifting. I'm not sure what a good solution would be for that, you could attempt to size the obscuration to be exactly the expected width of the word (difficult) and would require using a different number of characters relative to the length of the word. you could solve that problem by something like "tap to see how many characters this word is" but I've only ever used js popup libraries rather than in plain js so, not sure if that's an ideal solution.