search

larsgw / censordle

Guess Wikipedia article titles based on the censored contents of their articles
https://larsgw.github.io/censordle/
MIT License
2 stars 2 forks source link

Support alternative article banks/libraries #22

Open hexylena opened 1 year ago

hexylena commented 1 year ago

This is a (proposal) for supporting alternative sets of articles. Instead of the default vitality level 4 articles, it is expanded to include also (as a demonstration, but should also be entertaining) the "Unusual" articles.

Current minuses:

As data.js (now library/censordle.json) is no longer loaded automatically during page parsing, but rather as the JS processes, a preload head element has been added for this file specifically to improve first load time.

larsgw commented 1 year ago

Thank you again for your contributions! (this goes for #21 and #20 as well)

larsgw commented 1 year ago

Just to give an update on the state of my thought process (if you're wondering what's taking so long):

  1. I'm wondering whether unnecessarily preloading the default library has consequences.
  2. I'm considering what to do about the shared theme settings.
  3. I think I want to add a button immediately, + maybe a suggestion when people finish the regular daily article.

Just to clarify, I'm happy to do all of that myself but I just wanted to give you an update.

Regarding (1), maybe that's not even needed much anymore with the service worker. It shaved off 100 ms (of 200 ms) on the localhost but that would only be the first load.

hexylena commented 1 year ago

if you're wondering what's taking so long

There is no rush, I made the PR over summer holidays when I had some time and am unfortunately back at work which means I'd forgotten all about the fun parts of coding in life :sweat_smile:, no dramas.

I'm considering what to do about the shared theme settings

From my perspective it could probably just be extracted into a global censordle setting, or just store in the 'default' game, but I didn't find the time to refactor that (and wanted to see how you felt about it first)

Oh good point with the SW, I didn't consider that, and, yeah, possibly largely unnecessary then.

Just to clarify, I'm happy to do all of that myself but I just wanted to give you an update.

Appreciate the update and offer! Apologies to put more work on your plate but thank you for considering this PR and the best way to integrate it! :)

larsgw commented 1 year ago

The level 5 article lists are nice too, you can play in different categories. https://en.wikipedia.org/wiki/Wikipedia:Vital_articles/Level/5