Move to Node.js' assert.js

larsgw / citation.js

Citation.js converts formats like BibTeX, Wikidata JSON and ContentMine JSON to CSL-JSON to convert to other formats like APA, Vancouver and back to BibTeX.

https://citation.js.org/

MIT License

222 stars 30 forks source link

Move to Node.js' assert.js #137

Open larsgw opened 6 years ago

larsgw commented 6 years ago

PRO

A dependency less
No more issues with 'use strict' (#55, 7c475b614577991ec10a992261a457ea0116de7b)
Same functionality
Supported by browserify
Maintained by the Node.js people themselves (expect.js hasn't been updated since 2015)

CON

A system library (but does that really matter?)
It takes time to switch (especially since it's assert-style, not expect-style)

larsgw commented 5 years ago

A lot of these are converted while rewriting the tests for the new repository: https://github.com/citation-js/citation-js/commit/57ba9ff6ef3bd3220085d1d4847ff951bd4f9242#diff-098f6bcd4621d373cade4e832627b4f6. Only the core package tests are still expect.js.