search

larsgw / citation.js

Citation.js converts formats like BibTeX, Wikidata JSON and ContentMine JSON to CSL-JSON to convert to other formats like APA, Vancouver and back to BibTeX.
https://citation.js.org/
MIT License
222 stars 30 forks source link

Suddenly more coverage? #149

Closed larsgw closed 6 years ago

larsgw commented 6 years ago

Somehow, in two commits updating completely unrelated files, the coverage had a +5.08% uptick, which tells me they aren't completely unrelated. However, the only related thing I can imagine right now is moving the babel config (401de3e2b38219411b6ab86f8a4d0a853c78e28b).

larsgw commented 6 years ago

I added an issue report here: https://github.com/istanbuljs/nyc/issues/845. Perhaps it should be at the babel-plugin-istanbul, the istanbul or even the babel repo, but we'll see about that.

loganfsmyth commented 6 years ago

Pinged you on Slack but posting here in case anyone else comes across this. This was happening because there was a bug in babel.config.js support that was fixed in https://github.com/babel/babel/issues/7922, but this project is still using the version that does not include that fix.

larsgw commented 6 years ago

Thanks! Fixed in ea89c64b2051c7861b313c2dbe7428a5861dae0a.