Add possibility to use tag descriptions

larshp / ABAP-Swagger

Expose ABAP REST services with Swagger/openapi spec

MIT License

97 stars 40 forks source link

Add possibility to use tag descriptions #62

Closed BlackmanCC closed 3 years ago

BlackmanCC commented 4 years ago

Fixes #28 Tag descriptions can be added with method zcl_swag~set_tagdescription.

The use of externaldocs is optional.

BlackmanCC commented 4 years ago

@larshp sorry, but I cannot find a Indentation problem. abaplint says "Reduce method length to max 160 statements, currently 161"

larshp commented 4 years ago

its the number of statments in the method, suggest extracting some part of the method to a new method

BlackmanCC commented 4 years ago

its the number of statments in the method, suggest extracting some part of the method to a new method

@larshp all methods in zcl_swag have far less than 160 lines. the message must be an error.

larshp commented 4 years ago

the macros might count twice, one for the macro call and one for the statement inside the macro

BlackmanCC commented 4 years ago

the macros might count twice, one for the macro call and one for the statement inside the macro

@larshp which method has problem? do you have any recommendations for change or fix?

larshp commented 4 years ago

cool

there might be a bug, I've opened https://github.com/abaplint/abaplint/issues/1572

on long term I'd like to get rid of the macros

BlackmanCC commented 4 years ago

cool

there might be a bug, I've opened abaplint/abaplint#1572

on long term I'd like to get rid of the macros

yeah, I also thought about killing the macro and substitute it by a method call, but in the current situtation a macro fits best, even I do not like macros ;-)

larshp commented 4 years ago

the whole JSON concatenation/build should be replaced with a class representing the JSON, sometime in the future...

I'll review the pull requests sometime, but its not at the top of my list this week...

BlackmanCC commented 4 years ago

the whole JSON concatenation/build should be replaced with a class representing the JSON, sometime in the future...

I'll review the pull requests sometime, but its not at the top of my list this week...

sounds good but do not understand what you mean, IU think it works now. take your time for review and let me know if you suggest any changes.

BlackmanCC commented 3 years ago

@larshp I hope you can check the requests... THX

BlackmanCC commented 3 years ago

@larshp Please also merge thios pull request

larshp commented 3 years ago

thanks 👍