larshp / ABAP-Swagger

Expose ABAP REST services with Swagger/openapi spec
MIT License
97 stars 40 forks source link

Importing parameter definitions misnamed #75

Open erichopp opened 3 years ago

erichopp commented 3 years ago

This is exposed by https://github.com/larshp/todo_logic.

The importing parameter reference is named by _|"schema": {"$ref": "#/definitions/{ is_meta-meta-handler }Request"}| "/create":{ "post":{ "summary":"Create", "description":"", "parameters":[{ "name":"IS_DATA", "in":"body", "schema": {"$ref": "#/definitions/CREATE_Request"}}],

But the definition referenced is added to mt_definitions in method request by _lv_string = |"{ is_parameter-type }": {{ lvtype }}|. "ZTODO_DATA": {"type":"object", "properties":{"TEXT":{"type":"string" }}}

The same happens with delete as well as create.

larshp commented 3 years ago

thanks, pull requests welcome

however, I'm planning to move everything to https://github.com/abap-openapi, and rewrite this sometime, so it can be tested using https://github.com/open-abap