larshp / abapGitServer

Git server implemented in ABAP
MIT License
64 stars 25 forks source link

Error with space in name #143

Closed larshp closed 3 years ago

larshp commented 3 years ago

Ran into this same error message, though with a blank space in the name of the repo: git has no trouble creating or managing such a repo, but abapGitServer will not accept it. git will complain about a space in a branch name, so I'm not sure this is a case worth fixing, just being aware of it might be enough.

Originally posted by @AndreaBorgia-Abo in https://github.com/larshp/abapGitServer/issues/87#issuecomment-732080605

larshp commented 3 years ago

@AndreaBorgia-Abo suggest a simple fix, make the repo creation dump at

https://github.com/larshp/abapGitServer/blob/master/src/backend/zcl_ags_repo.clas.abap#L101

if the name contains a space

AndreaBorgia-Abo commented 3 years ago

On it.

larshp commented 3 years ago

its not really user friendly, but easy and friendly'er than failing later

AndreaBorgia-Abo commented 3 years ago

Yes, I agree. I'll use this opportunity to learn about the PR workflow when abapGit is involved.

larshp commented 3 years ago

few hints at https://docs.abapgit.org/guide-contributing.html

JanisB-AT commented 3 years ago

And now abapGitServer can only create a repo whose name is full 20 chars long, at least from the UI... :) #144 #

larshp commented 3 years ago

the repo name have always been 20 characters in the database, so its not caused by https://github.com/larshp/abapGitServer/pull/144

image

larshp commented 3 years ago

this issue is fixed by https://github.com/larshp/abapGitServer/pull/144 closing