search

larshp / abapGitServer

Git server implemented in ABAP
MIT License
64 stars 25 forks source link

Update abaplint.json #172

Closed AndreaBorgia-Abo closed 1 year ago

AndreaBorgia-Abo commented 1 year ago

AGS should theoretically be able to run wherever ABAP-Swagger does, so we need to check for 7.02 syntax

AndreaBorgia-Abo commented 1 year ago

@larshp is it feasible to have different severity for different versions? v740sp08 -> error v702 -> warning This way, it could be merged and be useful but not get in the way of the lucky ones with modern(ish) systems. (I'm asking because fixing the code for our oldest system is low priority, it is more than good enough that it works on two different systems, one of which did require the downport)

larshp commented 1 year ago

yea, its possible see https://github.com/open-abap/open-table-maintenance/blob/main/abaplint-app.jsonc

but I dont think its worth it, in a CI setup things should be green

AndreaBorgia-Abo commented 1 year ago

we may never get around to carry out the required changes, since we installed a gitea instance... I wanted a way to highlight the issue without it being blocking, that's all.

larshp commented 1 year ago

ok, think I'll close this PR then, feel free to open an issue