Rest call failed

[treisinger]

I installed AbapGit and AbapGitServer. I also installed Abap-Swagger as pre-requisite and my Basis-Version is 750 0005.

I created a Repository in AbapGitServer and assigned to a development package within AbapGit. I did also commits to the Repository in AbapGitServer.

From AbapGit point of view, everything look fine.

But I do get an error, when I try to access the repository in AbapGitServer.

Best regards, Tapio

[larshp]

hmm, try setting an external breakpoint in class ZCL_AGS_SERVICE_REST method LIST_BRANCHES, and see where/if it fails

Does the overview page work, ie. the page showing the abapGitServer repositories?

[treisinger]

Overview is fine, I guess.

Create and Edit a Repository works fine. Anything else will produce the REST call failed error.

It will not stop at LIST_BRANCHES. As I said it happens also when I click at files or commits.

[larshp]

hmm, try to see if it hits class ZCL_AGS_SICF method IF_HTTP_EXTENSION~HANDLE_REQUEST

[treisinger]

Yes, it stops at IF_HTTP_EXTENSION~HANDLE_REQUEST. In the following processing an exception is triggered and immidiately after this eexception the error comes up.

But I'm not really sure it's the reason as this exception is also triggered when it displays the overview page, which seams to work correct. The exception is caught in class CL_HTTP_SECURITY_SESSION_ADMINCP method get_current_access_policy. It is raised in method get_current_session_context, because function module TH_GET_SECURITY_CONTEXT_REF did not set field flag_is_set for security context. I tried to set field flag_is_set to true, but still the error appears. I looked in SAP notes for class and function module, but I really do not have enough experience in this area of development to decide which note could be relevant and which not.

[treisinger]

I also tried to call the manual swagger interface which can be accessed from overview page. There it did not work as well.

[treisinger]

Ok, it seems AbapGitServer cannot deal with Hyphen/Minus ("-") Charakter in Repository name. I created several new repos and when "-" is included in name, I get the error. If I do not use it everything works fine.

Is there a way to delete the wrong repositories?

[larshp]

use program https://github.com/larshp/abapGitServer/blob/master/src/frontend/zags_repo_delete.prog.abap

Keep the issue open, I want to fix the issue sometime, either by changing the code, or adding a validation on the repo name

[larshp]

Thanks, dashes should work now, try latest version

fixed in https://github.com/larshp/abapGitServer/commit/16d52401d49082aa841abb1703d95ca4288517b4

[AndreaBorgia-Abo]

Ran into this same error message, though with a blank space in the name of the repo: git has no trouble creating or managing such a repo, but abapGitServer will not accept it. git will complain about a space in a branch name, so I'm not sure this is a case worth fixing, just being aware of it might be enough.