search

larshp / abapGitServer

Git server implemented in ABAP
MIT License
64 stars 25 forks source link

error when doing git pull using normal git client again #95

Closed cpoliwoda closed 6 years ago

cpoliwoda commented 6 years ago

If I tried to pull in the gitBash a change that was made in se80 and commited via abapGit. nothing happend. the git versions that was tested by me were 2.10.2.windows.1 and the most recent 2.15.1.windows.2.

the steps I've done were the following ones:

larshp commented 6 years ago

how many objects are there in the repository? Does it work cloning the repository using gitBash?

Update: I have reproduced the issue, the code stalls in negotiate_packfile

temporary workaround is to git clone the repo instead of pulling. Are you planning to do ABAP changes outside a ABAP server?

cpoliwoda commented 6 years ago

Thank you for the workaround.

Currently I'm experimenting with abapGit and abapGitServer to test if it could be used in our Company.

I personally would prefer to have the choice to decide were I want to develep inside SAP with se80 or outside in an editor like VS Code local on my PC with no need to connect to the system.

At the moment I would prefer the possibility to work outside a ABAP server because that way it feels for me more similar like developing in other languages with the features from modern IDE's. That way more persons could work on the same files without to block each other, merge the changes locally on their PC's and push their solution back to the ABAP server.

SAP is also pushing eclipse to be used for backend developing in content of Fiori and S4/HANA. So it is just a question of time, when we need to use extern tools to develop ABAP coding outside of an ABAP server, in my point of view.

larshp commented 6 years ago

yeah, true, I'm just curious 😄

Will look into the issue when I get some time, perhaps this week.

Thanks for testing

larshp commented 6 years ago

@cpoliwoda try again, latest version

I've previously had this working, https://twitter.com/LarsHvam/status/889151186254917632 but it must have been without the no-done capability.

Details: https://www.kernel.org/pub/software/scm/git/docs/technical/pack-protocol.html#_packfile_negotiation https://www.kernel.org/pub/software/scm/git/docs/technical/protocol-capabilities.html#_no_done

cpoliwoda commented 6 years ago

it works now. :smiley:

pushing and pulling worked from ababGitClient, gitBash and VS Code for me.

gregorwolf commented 6 years ago

Hi @cpoliwoda this is just a comment to https://github.com/larshp/abapGitServer/issues/95#issuecomment-355238730 - Have you ever worked with ABAP in Eclipse? You will see that it is also a very server based approach. I.E. you have server side locking of objects as soon as you start editing them. I get where you want to go, but I think a strength of AiE or even SE80 is the system wide code completion which would require a complete ABAP repository download if you want to provide that without server connection.

larshp commented 6 years ago

^ we will hopefully get there sometime, being able to do local ABAP development without a big ABAP stack 😜

larshp commented 6 years ago

closing the issue, feel free to discuss above.

pull works now, but there is still a lot that can go wrong, it is crazy to develop a git server in custom ABAP code, but it gets better every now and then, one step at a time 😄

cpoliwoda commented 6 years ago

Hi @gregorwolf I've tried ABAP in Eclipse about one year ago by my own without checking if the file which I'm editing is blocked for a colleague.

I'm with you that that code completion and forward navigation are great features in se80.

Two thinks which I like in eclipse are that there is no limit with open sessions like in SAP Logon and that the sessions didn't terminated if the connection to the SAP system is temporary interrupted, if you change your network connection from WiFi to cable or vice versa.

It's a pity, that not all feature which are available in AiE could be used in eclipse on each SAP system or even connect to it, because of the dependencies to the versions of to the installed sap components, but that's an other theme. It would be a great thing if the developer tools did not depend on the SAP system version on which somebody work with.

As larshp said "hopefully get there sometime" and "it gets better every now and then, one step at a time".

You guys did a great job. regards and thank you.