search

larshp / abapOpenChecks

Open source checks for SAP Code Inspector / ABAP Test Cockpit
https://docs.abapopenchecks.org
MIT License
270 stars 79 forks source link

Added CLEAR WITH #1061

Closed MartinH1337 closed 2 years ago

MartinH1337 commented 2 years ago

The check for "CLEAR ... WITH" was added as permissible. In doing so, the condition according to "think positive" was reversed.

larshp commented 2 years ago

can you reduce the line length, as noted by abaplint, https://github.com/larshp/abapOpenChecks/pull/1061/checks?check_run_id=4984072786

MartinH1337 commented 2 years ago

done.

MartinH1337 commented 2 years ago

What do you think of an attribute allowing this CHECK x WITH y? Necessary? I have the code ready and tested, just because I wanted to try it out.

larshp commented 2 years ago

1060

larshp commented 2 years ago

not nessesary, I think CLEAR WITH can be seen as an an assignment

larshp commented 2 years ago

thanks, welcome to abapOpenChecks as a contributor 🎉

MartinH1337 commented 2 years ago

thanks a lot for your warm welcome. I am very excited as this is my first contribution to a github.