search

larshp / abapOpenChecks

Open source checks for SAP Code Inspector / ABAP Test Cockpit
https://docs.abapopenchecks.org
MIT License
270 stars 79 forks source link

ATC Check 69: RFC enabled? #1078

Open cavabap opened 2 years ago

cavabap commented 2 years ago

Hello,

would it be possible to make Check 69 remote enabled? Or is that too difficult. I don't mind submitting the PR, but it'd be great to get an idea what I'd need to change in advance.

What I could find that clearly isn't remote enabled was this. SELECT SINGLE subc FROM reposrc INTO lv_subc WHERE progname = object_name AND r3state = 'A'.

Could this be replaced with RFC_READ_TABLE? What else would need to be exchanged?

Thanks in advance

Martin

larshp commented 2 years ago

well, the central system does not know the types, which makes it difficult

cavabap commented 2 years ago

you mean like idoc function module, etc. But how is the check determining it? and could this be done via READ TABLE? Would you accept a pull request for that? Otherwise we might consider enhancing the coding to enable it but it be great to get a few pointers about what parts of the class do I need to replace...

larshp commented 2 years ago

my recommendation is to not spend time on it, central ATC is more or less broken by design

however, it is possible to implement in https://github.com/abaplint/abaplint