larshp / abapOpenChecks

Open source checks for SAP Code Inspector / ABAP Test Cockpit
https://docs.abapopenchecks.org
MIT License
270 stars 79 forks source link

Fix/check 02 allow old syntax 4 select option #1122

Open alezhu opened 11 months ago

alezhu commented 11 months ago

IF we have code with default value for select-option like this: SELECT-OPTIONS s_date FOR d DEFAULT '20231207' SIGN I OPTION GE MODIF ID mr. the check is raising error 'Use new operator' because we use 'GE' instead of '>='. But in select-options we have to use only 'old' operators.

This PR fix it.

Additionally, the is_old method continues searching for a pattern in the statement even if it has already found one. Fixed that too.

Also use regular expression to find patterns for include and exclude, because CP has problem. For example for iv_statement CP '* EQ TYPE *: DATA eq TYPE C. - valid DATA eq TYPE C. - invalid (2 spaces before and after TYPE)