larshp / abapOpenChecks

Open source checks for SAP Code Inspector / ABAP Test Cockpit
https://docs.abapopenchecks.org
MIT License
270 stars 79 forks source link

Notification emails #1130

Closed HOUNDmx closed 10 months ago

HOUNDmx commented 10 months ago

See https://github.com/larshp/abapOpenChecks/issues/1129

Overall approach: A parameter on the selection screen, so it can be easily scheduled as a periodical job.

When parameter is checked, program logic groups findings by user, loads an email template either from SO10 or from provided parameters, gets user email address and sends the findings to the users.

Tested in NW, SAP_ABAP 7.5, running no problem, working fine with 2 different recipients, each with their own list of items.

Additional changes:

Good to have:

HOUNDmx commented 10 months ago

I have a suggestion for simplifying the code.

Maybe you should try it out to see if it works.

I'll give it a try tomorrow, thanks!

HOUNDmx commented 10 months ago

I have a suggestion for simplifying the code. Maybe you should try it out to see if it works.

Tried and tested, works fine šŸ‘

HOUNDmx commented 10 months ago

Some ideas popped up on easier customization for the email contents, will commit some more changes

larshp commented 10 months ago

his this part needed? if the text id is filled, load it, else not image

HOUNDmx commented 10 months ago

his this part needed? if the text id is filled, load it, else not

what if the user fills out text id, name, subject and some text in the buttons? would it still load from db?

imo I prefer having the options clearly separated and the user having to deliverately choose between them

larshp commented 10 months ago

cool, thanks šŸ‘

welcome to abapOpenChecks as a contributor