larshp / abapOpenChecks

Open source checks for SAP Code Inspector / ABAP Test Cockpit
https://docs.abapopenchecks.org
MIT License
270 stars 79 forks source link

Check 47: false positive for obsolete statements #1148

Closed BiberM closed 4 months ago

BiberM commented 5 months ago

Dear Community,

we found a false positive within our code base for this check.

I suppose it is only targeted at RFC calls as the EXCEPTION token only exists there.

Based on the ABAP Docu ( Link ) there exist two obsolete statements that also have this token "DESTINATION". The check currently checks explicitely the fourth token where it must be when writing RFC function calls. But the obsolete statements NEW-PAGE and SUBMIT can have the token "DESTINATION" also at fourth place.

My recommendation would be to check explicitely for "CALL FUNCTION" in token 1 and 2.