search

larshp / nwabap751

Dockerfile for ABAP Developer Edition 7.51 SP02
MIT License
23 stars 7 forks source link

Consider adding copy of *.rar files in DockerFile #7

Open sorenviggo opened 6 years ago

sorenviggo commented 6 years ago

Please consider a prerequisite step as suggested in https://github.com/nzamani/sap-nw-abap-trial-docker The step would be to create a local folder called 'sapdownloads', and then adding all .rar installation files to this. The DockerFile then should have this line added. COPY sapdownloads /tmp

Then no other manual steps would be needed.

larshp commented 6 years ago

yeah, I havent really maintained this for a while, the one by @nzamani is good :)

sorenviggo commented 6 years ago

I have tested both, but actually find yours to be superior, due to the local '/tmp/install.sh' script you are creating, to perform the unrar locally in the container. But with very little effort, you could adopt 2 small enhancements from @nzamani, then yours would be perfect. If you add the prerequisite step with creating the folder, and adding below 2 lines in the DockerFile, then you can install the entire SAP system, by running only 3 commands in the cmd. 

RUN mkdir /run/uuidd && chown uuidd /var/run/uuidd && /usr/sbin/uuidd
COPY sapdownloads /tmp

Brgds, Søren.

larshp commented 6 years ago

Pull requests welcome 😄