search

larshp / upDOWNci

Upload and download SAP Code Inspector variants in XML format - ABAP
MIT License
27 stars 12 forks source link

Fix crash when check class uses local instead of global types #30

Closed ConjuringCoffee closed 6 months ago

ConjuringCoffee commented 7 months ago

Fixes #6

I've adapted the proposed solution of @stefan-riedelseifert into the new method GET_TYPE_DESCRIPTION.

I don't really understand why the proposed solution was to call objectdescr->get_attribute_type though. Calling get_type seemed more sensible to me.

ConjuringCoffee commented 7 months ago

I'll keep this pull request open in case Stefan has additional feedback next week. After that I'll merge it.

ConjuringCoffee commented 6 months ago

I was in contact with Stefan and he doesn't remember why he suggested get_attribute_type instead of get_type. That's totally understandable seeing as it was six years ago.