IBwWG
commented
8 years ago Hmm, not sure if my fix is bad, or it's another issue, but the grid only returns one row, when it should return more. Also, it seems to have the project mismatched with the rest of the data (test project vs my actual submitted ones from my project.)
If I go to grid.php without any parameters, it lists everything (and nothing is mis-matched), but with the empty parameters as sent by Firefox, I only get the one row (if I set the project to "all" or to the one that most of the line's data comes from. Even though the line says "test", setting project to "test" makes nothing show.)
Although, it seems to be related to what happens to be selected in the three selection boxes (type/file/function)...if I manually click the top then shift-click the bottom in each of those (sadly, ctrl+A doesn't work; also shift-reload doesn't clear my selections) and then click Apply Filters, I get more of the data (4/7 rows; I guess the 4 unique spots), but every row still says (as the server returned in this case, but not grid.php plain vanilla) Test Project.
OK, a couple shift-reloads in a row worked....now the data appears correctly in the table.
I didn't think this was related to this PR; however, the method of converting values into references may be flawed...
Although, it doesn't seem to be: if I compare $refs to $params they look the same:
array(6) { [0]=> &string(5) "iiiii" [1]=> &int(1) [2]=> &string(1) "0" [3]=> &string(1) "5" [4]=> &int(0) [5]=> &int(50) }
array(6) { [0]=> &string(5) "iiiii" [1]=> &int(1) [2]=> &string(1) "0" [3]=> &string(1) "5" [4]=> &int(0) [5]=> &int(50) } So, maybe it's a combination of a client-side flaw (i.e. probably it used to work, and then browser behaviour changed) and how the PHP code handles the difference.
Fixes #20 and #25 , although #25 was just caused by my not-quite-ready PR...