search

larsiusprime / crashdumper

A cross-platform automated crash report generator/sender for Haxe/OpenFL apps.
MIT License
113 stars 33 forks source link

Game id missing by default, preventing reports from being generated #36

Open mastef opened 8 years ago

mastef commented 8 years ago

It seems ERROR_PROJECTNAME in the php server is by default set to game id which the client never sends

https://github.com/larsiusprime/crashdumper/blob/d49565fac30ac84b394e73b6119a5002f2e765c2/servers/crashdumpbrowser/includes/constants.inc.php#L18

Since strlen($project) returns 0, the error never gets submitted

https://github.com/larsiusprime/crashdumper/blob/d49565fac30ac84b394e73b6119a5002f2e765c2/servers/crashdumpbrowser/report.php#L90

What worked in my case was changing the value to "package"

define("ERROR_PROJECTNAME", "package");

IBwWG commented 8 years ago

I fixed this in https://github.com/larsiusprime/crashdumper/pull/24/commits/97e84bf1ba26d0d111ba77fc73d3b537f09464b0 using "sess.ID" instead :)

mastef commented 8 years ago

Don't think sess.ID is the right one in this case as it'd be always unique?

IBwWG commented 8 years ago

You'd think so from the name...IIRC though it's not exactly so. I'd have to look again, but at the moment it does seem to be doing the right thing this way, somehow--I have one project per project in the server browser, not one per session. (And I have about 90 crashes spanning several versions.)