Fix haxe.xml.Fast deprecation warnigns with Haxe 4

larsiusprime / firetongue

A translation/localization framework written in Haxe

MIT License

144 stars 32 forks source link

Fix haxe.xml.Fast deprecation warnigns with Haxe 4 #34

Closed Gama11 closed 5 years ago

Gama11 commented 5 years ago

Compilation with Haxe 4 currently produces the following warning for each usage of Fast:

Warning : This typedef is deprecated in favor of haxe.xml.Access

This fix is the less invasive version where the old name (Fast) is kept. In Flixel libs, I did it the other way around and replaced usages with the "modern" Access naming (https://github.com/HaxeFlixel/flixel/commit/b6f954c7a30e8b58f2bf44b3f9fe6c8e1b3c0150). Not sure which one you prefer.

larsiusprime commented 5 years ago

I agree that in flixel libs it's better to update the syntax; for this library, it's a nice quick patch that I can verify visually without having to worry much about side effects, especially coming from you.