search

larsiusprime / polymod

Atomic modding framework for Haxe
MIT License
162 stars 62 forks source link

i think i fixed the path for the keys #100

Closed ghost closed 2 years ago

ghost commented 2 years ago

i think i fixed the path for the keys

approachcircle commented 2 years ago

i'll apply those changes locally on my installation of polymod to test them, and i'll post the results after

approachcircle commented 2 years ago

after applying the changes, it seems like it just broke things even more, these errors now get displayed: C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:20: characters 39-52 : Class<openfl.utils.AssetCache> has no field getBitmapKeys C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:20: characters 15-54 : You can't iterate on a Dynamic value, please specify Iterator or Iterable C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:22: characters 28-44 : Class<openfl.utils.AssetCache> has no field removeBitmapData C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:24: characters 39-50 : Class<openfl.utils.AssetCache> has no field getFontKeys C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:24: characters 15-52 : You can't iterate on a Dynamic value, please specify Iterator or Iterable C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:26: characters 28-38 : Class<openfl.utils.AssetCache> has no field removeFont C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:28: characters 39-51 : Class<openfl.utils.AssetCache> has no field getSoundKeys C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:28: characters 15-53 : You can't iterate on a Dynamic value, please specify Iterator or Iterable C:/HaxeToolkit/haxe/lib/polymod/1,4,2/polymod/backends/OpenFLBackend.hx:30: characters 28-39 : Class<openfl.utils.AssetCache> has no field removeSound

ghost commented 2 years ago

ohhh use this openfl

ghost commented 2 years ago

https://github.com/MasterEric/openfl

ghost commented 2 years ago

ima just wait for master eric to fix it

approachcircle commented 2 years ago

okay i'm super confused now, i made your changes locally on my installation of polymod, and i even removed my old version of openfl and installed master eric's fork of it which includes the functions for getBitmapKeys() etc, but haxe is still complaining that: Class<openfl.utils.AssetCache> has no field getBitmapKeys Class<openfl.utils.AssetCache> has no field getFontKeys Class<openfl.utils.AssetCache> has no field getSoundKeys and also that: Class<openfl.utils.AssetCache> has no field removeBitmapData Class<openfl.utils.AssetCache> has no field removeFont Class<openfl.utils.AssetCache> has no field removeSound even though i can see that those functions exist in that class??

i have no idea why polymod still can't find those functions in the AssetCache class, when they're obivously there.

EliteMasterEric commented 2 years ago

@approachcircle there is a method to fix this issue that fixes it for whatever version of OpenFL is in use. I will work to get it in place for the release of 1.5.0.

approachcircle commented 2 years ago

will it fix the issue where polymod can't see the methods that you added in your fork of openfl that i talked about here? and if not, what is the fix actually gonna be?

approachcircle commented 2 years ago

@MasterEric i actually just fixed all of the issues, and now fnf compiles which is what i've been trying to do from the beginning, and the fixes i've made don't require you to change your fork of openfl at all, so i'll open a pull request to merge all of the fixes