search

larsiusprime / polymod

Atomic modding framework for Haxe
MIT License
162 stars 62 forks source link

fixes a syntax error in a string #103

Closed approachcircle closed 2 years ago

approachcircle commented 2 years ago

(the information below no longer applies, and is outdated)

this pr will fix all issues with the openfl backend, provided that this fork of openfl is used (default branch), instead of the base repository

should close issues #102, #97 and #91 if merged

approachcircle commented 2 years ago

another notice

when this pr is merged into the main branch of openfl, you will then be able to install openfl via haxelib install openfl, but for the time being, you should remove the current version of openfl (haxelib remove openfl) and use master eric's fork by running haxelib git openfl https://github.com/MasterEric/openfl

ghost commented 2 years ago

Thank you sooo much

ghost commented 2 years ago

i will add this to my fork

approachcircle commented 2 years ago

while this pr should fix any syntax errors where haxe cannot find certain functions in AssetCache.hx (causing the OpenFL backend problems), it also creates logic errors where polymod will not actually use the new AssetCache instance i have created, and so it is not recommended to use any of these changes.

@beeanie i would advise you to delete these changes that you made on your fork too.

approachcircle commented 2 years ago

actually, on second thought, closing this PR completely probably isn't the right thing to do as one of the commits is still beneficial, so i'll reopen it and revert the commits which are not needed

EliteMasterEric commented 2 years ago

Thanks, I'll accept that change.

Since this appears to be an issue for people I'm suspending work on 1.5 to make a 1.4.3 to try to fix this.

approachcircle commented 2 years ago

thank you for pointing out where i got it wrong though, it definitely would've sucked if those changes i originally made got merged into the master branch.