Syntax error: PolymodFileSystem Expected ')'

[EliteMasterEric]

Discussed in https://github.com/larsiusprime/polymod/discussions/107

^{Originally posted by **hafimiee** March 5, 2022} C:/HaxeToolkit/haxe/lib/polymod/1,5,2/polymod/fs/PolymodFileSystem.hx:19: characters 16-18 : Expected )

[BoagerEpic301]

same

[EliteMasterEric]

This is weird because I haven't reproduced it myself.

@BoagerEpic301 What version of Haxe are you using?

[EliteMasterEric]

@hafimiee I'd also like to know your Haxe version to see if it's relevant to the issue.

[BoagerEpic301]

im using 4.1.5 for compiling kade engine

[BoagerEpic301]

nvm i just had to switch to 1.4.3 for it to compile correctly

[j0912345]

@MasterEric changing all occurrences of "is" to "==" in the if else statement fixes the error. PolymodFileSystem.zip

[applerex]

public static function makeFileSystem(cls:Dynamic = null, params:PolymodFileSystemParams):IFileSystem { if (cls == null) { // We need to determine the class to instantiate. return _detectFileSystem(params); } else if ((cls is Class)) { // Else, instantiate the provided class. return cast Type.createInstance(cls, [params]); } else { Polymod.error(BAD_CUSTOM_FILESYSTEM, "Passed an unknown type for a custom filesystem. Reverting to default..."); return makeFileSystem(null, params); } }

[Wo0fle]

@BoagerEpic301

You had to switch all the way from 4.1.5 to 1.4.3?????

Did you mean 4.1.3???

[EliteMasterEric]

Sorry I've been so busy, just posted a 1.5.3 with some minor fixes I've been working on, including a proper one for this issue.

[hayfidev]

@hafimiee I'd also like to know your Haxe version to see if it's relevant to the issue.

Sorry for a very late reply, it's the latest version of Haxe, I didn't saw any notifications.