search

larsiusprime / polymod

Atomic modding framework for Haxe
MIT License
161 stars 62 forks source link

Fix bad syntax in PolymodFileSystem.hx #114

Closed byemc closed 2 years ago

byemc commented 2 years ago

sorry, pressed enter accidentally, adding more details now...

byemc commented 2 years ago

Fixes the syntax error in PolymodFileSystem.hx

Solves issues #107 and #108, maybe more.

byemc commented 2 years ago

hiya, just checking in,

what's the progress on this PR? it reverses a pretty breaking change that stops the library working (for FNF modding anyway)

^bye

TON-Games commented 2 years ago

DEV PLZ FIX DA PROBLEM

EliteMasterEric commented 2 years ago

Sorry I've been so busy, just posted a 1.5.3 with some minor fixes I've been working on, including a proper one for this issue.

byemc commented 2 years ago

I was looking thru your changes and it doesnt look like it's fixed. I'm at school rn so I'll elaborate further

EliteMasterEric commented 2 years ago

I just looked through the changes your PR makes and they're ridiculous. You are comparing whether the variable IS the class, rather than whether they are an instance of the class.

byemc commented 2 years ago

I was just saying, after made those exact changes it fixed my problem (not being able to compile Friday Night Funkin') immediately. I don't actually know Haxe, I thought if I sent a PR with the changes that worked for me it could be useful to others. I just tested it now with a GitHub codespace for ninjamuffin99/Funkin and it's working fine. Thanks for fixing it!