search

larsiusprime / polymod

Atomic modding framework for Haxe
MIT License
162 stars 62 forks source link

[BUG] HScript compile error when hscriptPos is not enabled #122

Closed ghost closed 2 years ago

ghost commented 2 years ago

/usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:357: characters 17-18 : hscript.Error has no field e /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:373: characters 70-74 : hscript.Error has no field line /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:379: characters 70-74 : hscript.Error has no field line /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:384: characters 70-74 : hscript.Error has no field line /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:388: characters 69-73 : hscript.Error has no field line /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:392: characters 69-73 : hscript.Error has no field line /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:396: characters 69-73 : hscript.Error has no field line /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodInterpEx.hx:134: characters 9-15 : hscript.Interp has no field setVar /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodInterpEx.hx:115: characters 20-26 : Field setVar is declared 'override' but doesn't override any field /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:71: characters 52-56 : hscript.Error has no field line /usr/local/lib/haxe/lib/polymod/git/polymod/hscript/PolymodScriptClass.hx:74: characters 87-91 : hscript.Error has no field line

errors

TorchTheDragon commented 2 years ago

I found a temporary solution, here is my comment from the same issue elsewhere: https://github.com/larsiusprime/polymod/issues/121#issuecomment-1143074298

EliteMasterEric commented 2 years ago

I need to make the solution more robust so that it works with or without this change, but currently the issue is that these values only exist when the following is included in your Project.xml:

<haxedef name="hscriptPos" />

Add that and hscript.Error will have the line field and allow the project to compile.

AltronMaxX commented 2 years ago

<haxedef name="hscriptPos" /> Doesn't fix this:

C:/HaxeToolkit/haxe/lib/polymod/git/polymod/hscript/PolymodInterpEx.hx:134: characters 9-15 : hscript.Interp has no field setVar C:/HaxeToolkit/haxe/lib/polymod/git/polymod/hscript/PolymodInterpEx.hx:115: characters 20-26 : Field setVar is declared 'override' but doesn't override any field

EliteMasterEric commented 2 years ago

I've determined that the setVar issue is because the implementation of HScript is currently based on the git version, not 2.4.0 (which is outdated by about two years).

To fix it, run the following:

haxelib git hscript https://github.com/HaxeFoundation/hscript
ghost commented 2 years ago

I've determined that the setVar issue is because the implementation of HScript is currently based on the git version, not 2.4.0 (which is outdated by about two years).

To fix it, run the following:

haxelib git hscript https://github.com/HaxeFoundation/hscript

That does not work

ghost commented 2 years ago

i fixed it here #125

ghost commented 2 years ago

I've determined that the setVar issue is because the implementation of HScript is currently based on the git version, not 2.4.0 (which is outdated by about two years).

To fix it, run the following:

haxelib git hscript https://github.com/HaxeFoundation/hscript

well that fixes those 2 errors but i fixed the other errors for hscript

EliteMasterEric commented 2 years ago

Closed because hscript 2.5.0 is finally out and that has the fixes needed for Polymod.