search

larsiusprime / polymod

Atomic modding framework for Haxe
MIT License
161 stars 62 forks source link

Add a if statement so that you don't need to add the assetLibraryPaths unless you are crazy #87

Closed Cheemsandfriends closed 2 years ago

Cheemsandfriends commented 2 years ago

Hello, As I said in the Issue/trytoEnhancementthing number #85, I said that it would be great to add an automated thing to load your stuff. This adds the thing and pretty much it works like the old Polymod imo but even better

Cheemsandfriends commented 2 years ago

This is in case that someone is lazy (Me!!!) and doesn't want to be doing all that fuss of "folder name" => "./folder name"

ghost commented 2 years ago

can you add that to the polymod that you forked?

ghost commented 2 years ago

also i did what you did and i got this error /usr/local/lib/haxe/lib/polymod/git/polymod/Polymod.hx:164: characters 89-93 : Type not found : Path

Cheemsandfriends commented 2 years ago

also i did what you did and i got this error /usr/local/lib/haxe/lib/polymod/git/polymod/Polymod.hx:164: characters 89-93 : Type not found : Path

Oh oops. I forgot the import thing Wait a minute

Cheemsandfriends commented 2 years ago

@TheDisabledKid, I guess that now there isn't any errors now. If there is I forgot the path of importing the path but I think I'm correct lol

ghost commented 2 years ago

ok ima test it to see if it works

EliteMasterEric commented 2 years ago

This doesn't really make sense.

First off, this logic messes up with the HEAPS and Kha backend. Remember, they don't use Lime.

Secondly, the list of folders that are excluded is hardcoded. As it stands, a folder named img would get turned into an asset library.

The primary thing to remember is that having multiple asset libraries is an EDGE CASE that FNF happens to use. The default behavior of most Lime and Flixel applications is to use a single asset library default.

The current/planned behavior maintains compatibility with existing code and minimizes hassle in the default case, while allowing for intuitive and well-defined behavior in the edge case, while also maintaining support for other engines. I don't see a need to interfere with that.

I appreciate your attempts to contribute, but I'm going to close this change.

Cheemsandfriends commented 2 years ago

Hi @MasterEric!

I wanted to say that if you don't like the PR, it's Ok to do that, but at least please make a feature so it really isn't necessary to use the goddamn thing, if you don't use it, either it crashes or the mod doesn't even work.

First off, this logic messes up with the HEAPS and Kha backend. Remember, they don't use Lime.

I thought that it was obligatory to use the thing only in Lime, which it says it on the description of the thing. I'll add like a small thing to conclude that makes if params.framework == LIME thing. and then I'll check up how it works on different stuff. and I'll maybe add more stuff on the PR when I have an idea about it

The current/planned behavior maintains compatibility with existing code and minimizes hassle in the default case, while allowing for intuitive and well-defined behavior in the edge case, while also maintaining support for other engines. I don't see a need to interfere with that.

I don't want to be rude but it's a huge pain in the ass setting the customPathLibraries if you have a lot of libraries included. It's not a big deal to have like one or two folders in the assets thing. But imagine if the dev has like 15 or 20 folders and starts using Polymod. if you waaant support, add support for lazy devs that also want to just not completing the custom asset libary paths thing pls.

Please don't take this as a hated message towards Polymod cos you didn't accept this PR, I love the idea and it's one of the greatest thing I've ever seen! but the Asset Paths should be fixed the way it should work even if you don't set it. like it automatically sets it for you