larsks / docker-image-logitech-media-server

MIT License
33 stars 74 forks source link

Support for linux-amd64, linux-arm and linux-arm64 added #18

Open RaymondMouthaan opened 6 years ago

RaymondMouthaan commented 6 years ago

Added support for multiple architectures: linux-amd64, linux-arm and linux-arm64. Added support for docker manifest tool (no need for explicit architecture tagging). Update readme and docker-compose yml. Based upon Travis CI, to build and push the images to docker hub.

Howto:

Don't hesitate to contact me if you have questions.

Regards, Ray

MarkJonas commented 4 years ago

@RaymondMouthaan I did something similar you did. My pull request is also pending since some months.

Meanwhile I forked the project on GitLab: https://gitlab.com/toertel/docker-image-logitech-media-server

The fork supports amd64 (PC), arm32v7 (Raspberry Pi 2/3/4), and arm64v8. Additionally, images are built automatically using GitLab CI. Releases are pushed to Docker Hub.

It would be great hearing from you. :)

RaymondMouthaan commented 4 years ago

@MarkJonas

Sound like pretty much the same ;-) I stopped 18 months ago, since it seems the PR never gets merged. It's a good thing you created the docker images yourself. I will probably use them and give my Logitech Squeezebox a second life :-).

If I may suggest for your images: manifest them so that docker automatically pulls the right image for the appropriate architecture. This way one doesn't need to specify an explicit tag when an image gets pulled.

For example: assume you manifest the latest versions of arm32v6, arm32v7, arm64v8 and amd64 to tag latest. Then when toertel / logitech-media-server:latest gets pulled, Docker auto detects which architecture its running on and pulls the corresponding image for it. In case of Docker Swarm and Kubernetes with nodes of different architectures this becomes very handy and flexible.

An good example project is Node-RED Docker

If you need any help, don't hesitate to contact.

Regards & keep up the good work! Ray

SuperQ commented 4 years ago

Yes, using manifests is also how we publish multi-arch images for our projects.