search

larsks / dockerize

A tool for creating minimal docker images from dynamic ELF binaries.
GNU General Public License v3.0
355 stars 41 forks source link

Support python2 and python3 #20

Closed sebastien-rosset closed 4 years ago

sebastien-rosset commented 5 years ago

In python 2.x, subprocess.check_output returns a string. In python 3.x, subprocess.check_output returns an object of type <class 'bytes'>

This PR supports both cases so dockerize can run with python 2 or python 3.

pklaus commented 4 years ago

It would be great if you could merge this pull request. Currently, dockerize just silently continues although it failed to figure out the dependencies.

larsks commented 4 years ago

I've merged an alternative to this change that makes dockerize work with python 3. I'm not going to worry about python 3 compatibility going forward).