search

larsmagne / eplot

Emacs library for creating charts
https://lars.ingebrigtsen.no/2024/06/26/a-new-package-for-making-charts-in-emacs-eplot/
102 stars 3 forks source link

Support Emacs 28 by passing image-scaling-factor to image-compute-scaling-factor #5

Closed vjohansen closed 3 days ago

vjohansen commented 3 days ago

In Emacs 29 the first argument was made optional and defaults to image-scaling-factor

larsmagne commented 3 days ago

Does it otherwise work with Emacs 28? I rather doubt it, but I haven't tested.

vjohansen commented 3 days ago

I have only tried the first two examples in the README.md

These two work after the my change in an Emacs instance were I have compat-29.el installed (eg. to get defvar -keymap and possibly more)

larsmagne commented 3 days ago

Ah. In that case, it sounds like a good change, and I've now pulled it.