search

larstvei / Focus

Dim the font color of text in surrounding paragraphs
470 stars 14 forks source link

Focus shouldn't try to persist accross major mode changes #11

Closed thblt closed 7 years ago

thblt commented 7 years ago

See discussion on ffd97a5a3663103aa96945bb1d2f03481ab6229f.

larstvei commented 7 years ago

Agreed!

It was originally done because the focused area lingered when the major mode was changed, and there was no way to remove it (because the variables holding the overlays were killed). As you point out, minor modes generally shouldn't persist between major modes, and so a better solution is just to clean up on major mode change.

bfb6aaf should fix this.