search

larsvansoest / emote-clue-items

A RuneLite plugin which highlights items that are required for emote clue steps.
BSD 2-Clause "Simplified" License
7 stars 13 forks source link

Support Filtering Items in STASH Units #28

Closed Matthew-nop closed 2 years ago

Matthew-nop commented 2 years ago

Just found this plugin and it seemed like it would be a nice feature. There's likely a more efficient implementation, but hopefully this works well enough

larsvansoest commented 2 years ago

Thank you for contributing to this project. This is actually I feature that I was willing to implement in the future, so it's great that you went on and implemented this! I will give this a thorough look, I will get back to you 👍🏼

Matthew-nop commented 2 years ago

Thanks for the quick response! Sorry for the poor code formatting, I missed a few spots when cleaning it up. I'll fix up the inconsistencies now

larsvansoest commented 2 years ago

You're welcome! Don't worry too much about the formatting, my intellij settings will automatically apply them in review!

I tested out the source today and I really like the idea. I think it improves the user experience as it helps to maintain an easy overview of disposable items.

In terms of modeling, there are few things that I would like to adjust. I will explain more about it once I have my IDE open again!