[Solved] Filled STASHes not saving - maybe add "check all" option?

[kjholt]

I'm not sure if it's an issue on my end, but when I log in to RuneLite my built stashes are all marked as built but unfilled. A couple times I have gone through and checked them all off as filled, but it would be much easier with an option to mark all built stashes as filled.

The issue could be related to my having two different OSRS accounts with different RuneLite accounts/folders? It's possible I didn't set that up correctly but I followed the directions indicated by RuneLite.

Either way, this is one of my favorite plugins! Thank you so much!

[larsvansoest]

With current implementation, the stash filled status saving should act as follows.

1. The filled statuses are saved for each Runescape account you use.
2. 1. If you are logged into your runelite account, the account settings (1) should be synced accross your devices.
   2. If you are not logged into your runelite account, the account settings (1) should be stored on each runelite you open on your current device.

Would you mind verifying if you do in fact observe this behaviour? If the behaviour is different, there may be a bug, and I will then make sure to fix it right away!

Perhaps I can add a few buttons underneath the footer panel to help out with special cases, such as setting all stashes filled, etc. I will keep this in mind!

Thanks for your feedback and commendations!

[kjholt]

I am logged into runelite on two different accounts at the same time, and neither account has the info filled in/retained. Let me know what other information you need to identify the issue!

On Tue, Oct 26, 2021 at 3:16 PM Lars van Soest @.***> wrote:

With current implementation, the stash filled status saving should act as follows.

1. The filled statuses are saved for each Runescape account you use.
2. 1. If you are logged into your runelite account, the account settings (1) should be synced accross your devices.
   2. If you are not logged into your runelite account, the account settings (1) should be stored on each runelite you open on your current device.

Would you mind verifying if you do in fact observe this behaviour? If the behaviour is different, there may be a bug, and I will then make sure to fix it right away!

Perhaps I can add a few buttons underneath the footer panel to help out with special cases, such as setting all stashes filled, etc. I will keep this in mind!

Thanks for your feedback and commendations!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/larsvansoest/emote-clue-items/issues/33#issuecomment-952236432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJU4SSRXRWETA3SUSXO4NDUI4EDTANCNFSM5GYQJ2SA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[larsvansoest]

Thanks! So you are on one device, two runelite clients, logged into both clients with same runelite account, and then logged into two different runescape accounts? Are the fill statuses maintained after you reboot your clients?

[kjholt]

Actually, I'm on one device, logged into two runelite clients with two different runelite accounts, one for each runescape account. I followed the directions on the Runelite wiki here (under "playing with multiple accounts"): https://github.com/runelite/runelite/wiki/General-Features

[larsvansoest]

Thanks for letting me know! I will do some testing on my own!

[kjholt]

No problem! After the osrs update today the stashes are again unchecked (although it remembers which ones are built). As a test I went to a stash and withdrew/deposited and the status didn't change --- not actually sure if that would normally update the status though. I'm doing a few medium clues today (I have all but 1 medium stash filled, since as an ironman I don't receive the Arceuus library step) and will let you know if anything else noteworthy occurs.

On Wed, Oct 27, 2021 at 3:03 PM Lars van Soest @.***> wrote:

Thanks for letting my know! I will do some testing on my own!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/larsvansoest/emote-clue-items/issues/33#issuecomment-953225048, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJU4SVNZCQ7ETS6PPOVVSTUJBLIZANCNFSM5GYQJ2SA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[TomBoj]

I am also seeing this issue. I am signed into RuneLite and only ever use it for one account. I go through each one and mark it as filled, but when I next launch RunelLite and login to my account, they are all set as unfilled

[larsvansoest]

@TomBoj thank you for letting me know. How often are you experiencing this issue? And how many of the stashes are built on your account? It could be that there is an edge case for those that have all stashes unlocked. Ofcourse, that would be a bug that needs to be fixed.

[larsvansoest]

Bug Investigation

Status: reproduced Description: logged into a runelite account, logged into a runescape account, set all stashes as filled. On logout, an exception occured. After rebooting runelite, all fill statuses disappeared.

[TomBoj]

It seems to happen every time I close and relaunch RuneLite, I've just done it now. I have 3/3 beginner, 27/29 easy and 2/23 medium STASHs built and filled. I've attached a screenshot to show what the easy Stashes tab looks like when I login

[larsvansoest]

Thanks for letting me know! I have been able to reproduce the bug, I will start debugging and propose a fix. Thanks for actively reporting this issue, really helps improving the project!

[TomBoj]

No problem, thanks for such a great plugin

[larsvansoest]

@kjholt @TomBoj Thank you for reporting this issue. It should be resolved once plugin-hub:pr#2143 is accepted for release.

[larsvansoest]

The changes were merged today. With release https://github.com/larsvansoest/emote-clue-items/releases/tag/v3.3.0 the fix should now be live on RuneLite!