Trying to find flow_moe_ratios.csv

larsvilhuber / MobZ

https://larsvilhuber.github.io/MobZ/

3 stars 0 forks source link

Trying to find flow_moe_ratios.csv #24

Closed larsvilhuber closed 4 years ago

larsvilhuber commented 4 years ago

in the current README, ./modules/20.analysis/module_bootstrap.sas gets run after the first Stata program (02_flows.do in old numbering, 05_flows.do in new numbering). It reads in jtw1990_moe.csv.

There are no instructions that lead to that file. statado/flow_draws.do seems to write it out, but in turn, it reads in flow_moe_ratios.csv which I cannot find.

Lost...

andrewfoote commented 4 years ago

Just committed the file. The input is jtw2009_2013.csv, which I believe has already been documented elsewhere.

larsvilhuber commented 4 years ago

OK. I'll incorporate that into the streamlined sequence.

larsvilhuber commented 4 years ago

@andrewfoote I figured this out. The new program you uploaded was partially coincidental with the 02_flows.do (now 05_flows.do). But it was missing the part about saving files...

larsvilhuber commented 4 years ago

@andrewfoote There is a slight discrepancy between the old "02_flows.do" and parts of "flows_draw.do". I 'm going to assume the latter is the right version of the code, but preserve the other too. Let me know what can be "pruned".

02_flows.do:

https://github.com/larsvilhuber/MobZ/blob/3536306c01149297f73e0fc3f11eda3ed1b38368/programs/05_01_flows.do#L88-L104

flows_draw.do

https://github.com/larsvilhuber/MobZ/blob/3536306c01149297f73e0fc3f11eda3ed1b38368/programs/statado/flow_draws.do#L33-L54

larsvilhuber commented 4 years ago

Looks like ${outputs}/jtw1990_flows.csv is used nowhere else? (created at the tailend of 02_flows/ 05_01_flows.do)

andrewfoote commented 4 years ago

Looks like ${outputs}/jtw1990_flows.csv is used nowhere else? (created at the tailend of 02_flows/ 05_01_flows.do)

Yea I think you are right - I don't know why that is there. I will cut that.

andrewfoote commented 4 years ago

@andrewfoote There is a slight discrepancy between the old "02_flows.do" and parts of "flows_draw.do". I 'm going to assume the latter is the right version of the code, but preserve the other too. Let me know what can be "pruned".

02_flows.do:

https://github.com/larsvilhuber/MobZ/blob/3536306c01149297f73e0fc3f11eda3ed1b38368/programs/05_01_flows.do#L88-L104

flows_draw.do

https://github.com/larsvilhuber/MobZ/blob/3536306c01149297f73e0fc3f11eda3ed1b38368/programs/statado/flow_draws.do#L33-L54

It looks good now.