search

larsxschneider / ShowInGitHub

Xcode plugin to open the GitHub page of the commit of the currently selected line in the editor window.
BSD 2-Clause "Simplified" License
239 stars 41 forks source link

Use existing "Source Control" menu #24

Open noahemmet opened 9 years ago

noahemmet commented 9 years ago

Instead of creating a new "Github" menu bar item, the plug-in should use the pre-existing "Source Control" menu (maybe with a "Github" submenu). A whole new menu item with only two entries takes up a lot of precious menu real estate.

larsxschneider commented 9 years ago

Hi,

thanks for the suggestion. @mabedan did that already: https://github.com/larsxschneider/ShowInGitHub/pull/18

However, I wonder if and how we should tell people about the change. Otherwise they might feel confused because their Github menu is gone?

Would you be willing to pick you the existing PR and add some welcome message?

Cheers, Lars

noahemmet commented 9 years ago

Hmm, I suppose people might get a little confused, but I don't think a popup message is a good solution—it interrupts a user's workflow and I'd be pretty annoyed if plugins started popping up alerts when I launch Xcode. And really, the Source Control menu is a pretty intuitive place to look for github-related features.

You could change the text in the Alcatraz blurb to "Open the related Github page of a source file directly from the Source Control menu in Xcode", which would go a long way. Also, users can always search directly for specific menu items via the Help > Search menu item.

Nice job with the plugin so far!

cbowns commented 8 years ago

+1 for this change. And no, I don't think any migration is necessary: I imagine most users are using the keyboard shortcut; and I think adding a menu item (to the eleven already present!) is wasteful.