lartpang
commented
3 years ago Thanks for your PR.
Before merging your PR, there are still some issues to consider:
- [Not recommended] Why do I use the
plt.showinstead ofsavefig: (https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/pull/1/files#diff-516f388f4e623cb3ed4d19e382bd99a16a89c984ff899e4deeb2539b0621ac2cR109-R114) Saving directly is convenient, but it loses the more flexible customization ability to save through the displayed window. In the window, we can adjust the spacing between sub figures more intuitively, and support exporting files as more formats (such as pdf format, which can be easily inserted into TeX documents). So I hope you can consider this part commit carefully. - [Not recommended] The same is true here: https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/pull/1/files#diff-516f388f4e623cb3ed4d19e382bd99a16a89c984ff899e4deeb2539b0621ac2cL11-R12.
- [Need to be improved] Before releasing the code, I am the only user of it. So there may be some inflexible configurations that I may not have noticed, as following links. Maybe, could the format of label be more flexible?
- [Need to be improved] As for formatting, it is recommended to use the
pre-committool to format code before committing it, so that we can maintain the consistency of the format. (This made me realize that I should add a Github Action tool to automate the formatting code, but this does not solve the current problem. :disappointed: ) - [Need to be improved] It is worthwhile to separate the settings of axis information from the main configuration dictionary, which can reduce the complexity of user configuration. But why don't we put it in
./utils/as a common function? In this way, all the files (rgb cod, rgb sod, rgbd sod, rgb cosod: https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/blob/master/configs/__init__.py#L2-L5) can be used.
demo: