search

laruence / php-lua

This extension embeds the lua interpreter and offers an OO-API to lua variables and functions.
http://pecl.php.net/package/lua
Other
149 stars 50 forks source link

fix for latest php7 head #13

Closed hjanuschka closed 9 years ago

hjanuschka commented 9 years ago

hello

following changes enable compile against the current php7 master there is no if-def-dance - so it does not compile on php5.6 5.5 - but should be a quick one - or maybe keep it in a seperate branch?

make test passes all tests - maybe this is a inspiration for someone who is doing the php-lua builds!

note includes @ktemkin 's config.m4 patch for debian/ubuntu

hjanuschka commented 9 years ago

wow - fast - you sure it should be in the master branch? because it breaks building against any php version prior to php7-head?

could you add me to the LUA_AUTHORS (i forgot)

laruence commented 9 years ago

I will make a new release before PHP7 comes out.

sure, maybe you could send another PR? I will merge it(author)

laruence commented 9 years ago

maybe checkout a new branch for 5.x , of course before this commit

hjanuschka commented 9 years ago

ok i have no clue how to re-open that pull request did a new one #14 for the authors stuff.

right now i don't have the need for php5.x - but i try to get a devbox up and running and try to do the backport.

regards