Throw Exceptions instead of triggering Errors/Warninings

laruence / taint

Taint is a PHP extension, used for detecting XSS codes

Other

611 stars 128 forks source link

Throw Exceptions instead of triggering Errors/Warninings #52

Open staabm opened 7 years ago

staabm commented 7 years ago

Would be great when tain could be configured (e.g. using taint.error_level) to throw proper Exceptions instead of triggering Errors/Warnings.

That way would would have a proper backtrace and localisation of the actual errors would be way easier.

laruence commented 7 years ago

make sense.... I will do it later, or if you are interesting in it, you could do a PR ;) thanks

staabm commented 7 years ago

my C fu is very limited.. I try to learn but atm I cannot help you with things like this, sorry

staabm commented 7 years ago

I changed the way I integrate the extension with my code, so having it throw a Exception will no longer provide benefit for me. therefore we could close this issue.

my new approach is

register a error handler which turns taint-warnings into exceptions
in the error handler I filter out taint-errors from files which are not under my control (e.g. external dependencies etc.) as those need to be handled differently.