Observed: ... used as the getName()
Desired: args or some other valid php identifier for a variable name
This would be equivalent to function taint($string, $...), where ... is not a valid php identifier and it would be impossible for a user-defined function to use ... as a parameter name.
The use of an invalid identifier may cause issues for tools/ides/scripts that extract argument names from Reflection information.
(For https://wiki.php.net/rfc/named_params , the argument names of variadics don't actually matter, but tooling being able to extract valid identifiers from extensions is convenient)
(I'm currently working on checking dozens of extensions reflection information for consistency with other sources of type/parameter names)
https://github.com/laruence/taint/blob/2deabd57d1bff0cfb0bd8323dd396944ff29dbce/taint.c#L37-L45
Observed:
...used as the getName() Desired:argsor some other valid php identifier for a variable nameThis would be equivalent to
function taint($string, $...), where...is not a valid php identifier and it would be impossible for a user-defined function to use...as a parameter name.The use of an invalid identifier may cause issues for tools/ides/scripts that extract argument names from Reflection information.
(For https://wiki.php.net/rfc/named_params , the argument names of variadics don't actually matter, but tooling being able to extract valid identifiers from extensions is convenient)
(I'm currently working on checking dozens of extensions reflection information for consistency with other sources of type/parameter names)