search

larvit / larvitsmpp

SMPP made simple
MIT License
7 stars 7 forks source link

some fixes related to variable UDH header and Multipart SMS's #6

Closed qasimakhan closed 8 years ago

qasimakhan commented 8 years ago

reference: https://github.com/larvit/larvitsmpp/issues/1

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.9%) to 69.447% when pulling 7d0da6202c9de9687c3e99ed2ffc24d941d5fde9 on qasimakhan:master into 5da55e0f52c679056ccbfd6325524dcb0559c639 on larvit:master.

lillem4n commented 8 years ago

Thank you for this! If you could look over the code and make sure the tests all passes and that a new test testing the new functionality is in place that would be awesome.

If you do not have a chance to do so, I'll look into this in a few days and modify this in a new branch until we have new tests and all old tests passes. :)

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.7%) to 69.561% when pulling 8f1c94724cd51154b09bb8ff72f48b9838024ea0 on qasimakhan:master into 5da55e0f52c679056ccbfd6325524dcb0559c639 on larvit:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.7%) to 69.626% when pulling d811dd32f23370ef7bfd84e6eef638c5f5b66224 on qasimakhan:master into 5da55e0f52c679056ccbfd6325524dcb0559c639 on larvit:master.