Closed ehsanmasdar closed 8 years ago
@Oksisane Code looks good - let's test tomorrow at lunch.
@smo-key @oksisane you two are welcome to test on the 4290 bot.
On Thu, Oct 22, 2015 at 8:43 PM, Arthur Pachachura <notifications@github.com
wrote:
@Oksisane https://github.com/Oksisane Code looks good - let's test tomorrow at lunch.
— Reply to this email directly or view it on GitHub https://github.com/lasarobotics/FTCLibrary/pull/32#issuecomment-150404021 .
Thank you, @ethan-schaffer!
No problem @smo-key!
On Thu, Oct 22, 2015 at 9:04 PM, Arthur Pachachura <notifications@github.com
wrote:
Thank you, @ethan-schaffer https://github.com/ethan-schaffer!
— Reply to this email directly or view it on GitHub https://github.com/lasarobotics/FTCLibrary/pull/32#issuecomment-150411023 .
@Oksisane Tested. Please make a few changes:
signed = (unsigned >= 65526/2) ? 65525 - unsigned : unsigned;
should work, maybe some binary logic would be betterinit()
Also, the gyro is inaccurate when it moves really fast. Can you limit this somehow?
@homu r-
:umbrella: The latest upstream changes (presumably #35) made this pull request unmergeable. Please resolve the merge conflicts.
@smo-key Please test and sign off :)