lasarobotics / FTCLibrary

Generic function and autonomous library for the FTC Android Platform
MIT License
25 stars 14 forks source link

Modern Robotics Gyroscope Support #32

Closed ehsanmasdar closed 8 years ago

ehsanmasdar commented 8 years ago

@smo-key Please test and sign off :)

smo-key commented 8 years ago

@Oksisane Code looks good - let's test tomorrow at lunch.

ethan-schaffer commented 8 years ago

@smo-key @oksisane you two are welcome to test on the 4290 bot.

On Thu, Oct 22, 2015 at 8:43 PM, Arthur Pachachura <notifications@github.com

wrote:

@Oksisane https://github.com/Oksisane Code looks good - let's test tomorrow at lunch.

— Reply to this email directly or view it on GitHub https://github.com/lasarobotics/FTCLibrary/pull/32#issuecomment-150404021 .

smo-key commented 8 years ago

Thank you, @ethan-schaffer!

ethan-schaffer commented 8 years ago

No problem @smo-key!

On Thu, Oct 22, 2015 at 9:04 PM, Arthur Pachachura <notifications@github.com

wrote:

Thank you, @ethan-schaffer https://github.com/ethan-schaffer!

— Reply to this email directly or view it on GitHub https://github.com/lasarobotics/FTCLibrary/pull/32#issuecomment-150411023 .

smo-key commented 8 years ago

@Oksisane Tested. Please make a few changes:

Also, the gyro is inaccurate when it moves really fast. Can you limit this somehow?

smo-key commented 8 years ago

@homu r-

homu commented 8 years ago

:umbrella: The latest upstream changes (presumably #35) made this pull request unmergeable. Please resolve the merge conflicts.