search

laserlemon / figaro

Simple Rails app configuration
MIT License
3.76k stars 288 forks source link

Don't "require 'rails'" at require-time #205 #206

Closed l8nite closed 8 years ago

l8nite commented 9 years ago

This addresses issue #205 and stops figaro from explicitly requiring rails.

Here we go again

l8nite commented 9 years ago

@laserlemon any chance we can get this one merged in soon? :)

l8nite commented 9 years ago

@laserlemon ping? :)

jcampos8782 commented 9 years ago

+1

l8nite commented 9 years ago

Pushed a tiny change that moved the figaro/rails/application require inside the defined? Rails check.

hubert commented 9 years ago

:hatched_chick: this solves a real problem for gems that are using figaro both inside and outside the context of rails.

ak47 commented 8 years ago

+1

l8nite commented 8 years ago

hey @laserlemon following up on some old PRs, any chance we could get this merged and released?

l8nite commented 8 years ago

Closing and re-opening from my own fork because the practicefusion org fork is going to be nuked.