search

laserlemon / figaro

Simple Rails app configuration
MIT License
3.77k stars 288 forks source link

Already check entry in .gitignore for application.yml #259

Open tannakartikey opened 7 years ago

tannakartikey commented 7 years ago

Currently, even if the application.yml is ignored using .gitignore file, on running bundle exec figaro install, the entry is appended again.

The entry can be present already if you are not the only one in the team and someone started using Figaro before you.

JStans12 commented 7 years ago

I looked into this and found that if you have 

# Ignore application configuration
/config/application.yml

in your .gitignore, nothing will be appended. However, if you removed either of the two lines, it will append both lines and make the file redundant.

It seems that figaro should really only care about /config/application.yml. I'll put in a PR for this fix.

tannakartikey commented 7 years ago

We shouldn't hardcode the path also. So it should just care about application.yml

tannakartikey commented 7 years ago

@laserlemon your views?

laserlemon commented 7 years ago

As of today, we should hardcore the path because that's exactly where Figaro will look for it. Thank you for checking on this!