search

laserlemon / figaro

Simple Rails app configuration
MIT License
3.77k stars 287 forks source link

Removing thor version requirement allows rails 6 to bundle #283

Open Deekor opened 4 years ago

Deekor commented 4 years ago

Quick hack. Probably not the best fix but it allows rails 6 to bundle and seems to be working properly now

Deekor commented 4 years ago

Please consider merging @laserlemon

danielmorrison commented 4 years ago

I just ran into this, and this gets it bundling again. Rails 6 needs thor 1.0.

Rambou commented 4 years ago

For Fsake, can someone merge this and release a new version of Figaro? Firago also conflicts with Solargraph which depends on thor version 1.0.

danielmorrison commented 4 years ago

@Rambou I've volunteered to get this merged and updated, though it'll be a few days before I have time to finish that up.

In the meantime, pointing at @Deekor's branch should get you up and running. It is what I'm doing currently.

Deekor commented 2 years ago

@Rambou I've volunteered to get this merged and updated, though it'll be a few days before I have time to finish that up.

In the meantime, pointing at @Deekor's branch should get you up and running. It is what I'm doing currently.

Is this still a thing? :)

hlascelles commented 1 year ago

It tuned out this did happen here: https://github.com/laserlemon/figaro/commit/e932bbe3ad476dfc5ab9f465533b23bb351b09c0#diff-a28aa17ca50fb416dc54a8cda81f3873ed94d950397c5f094b0fa944939c646eR14

So gem version 1.2.0 of figaro allows higher Thor versions.