search

laserlemon / figaro

Simple Rails app configuration
MIT License
3.77k stars 287 forks source link

Change exist method for gitignore #291

Open muhenge opened 1 year ago

muhenge commented 1 year ago

-Fix typo in the ignore_configuration method

This pull request fixes a typo in the ignore_configuration method of the project's codebase. The current implementation uses File.exists? to check if a .gitignore file exists, which should be replaced with File.exist? for consistency with Ruby's standard library.

I have tested this change on my local machine and confirmed that it resolves the issue. Please let me know if there is anything else I can do to help get this change merged into the project.

joao-saraiva commented 1 year ago

This would fix on new versions but maybe crash on older versions, i think you should check the RUBY_VERSION, because old ruby versions still use .exists?

DavidAmyot commented 12 months ago

Any chance of this being merged soon? Have to work with a fork otherwise.

Thanks :)

CuddlyBunion341 commented 11 months ago

A merge would be quite nice

cooljl31 commented 10 months ago

I think this should already be merged, I almost wanted to create a new PR for the same Issue, can someone please merge this PR thanks :)

lucasfontes2604 commented 3 months ago

This would fix on new versions but maybe crash on older versions, i think you should check the RUBY_VERSION, because old ruby versions still use .exists?

The "exist?" method is also valid for old Ruby versions. The repository is using it in some files. Can someone with access merge this PR to solve the issue?

cc @laserlemon.

Jberma23 commented 2 months ago

I believe the new alternative in 7+ is Pathname.new(path_name).exist?