search

laserlemon / vestal_versions

Keep a DRY history of your ActiveRecord models' changes
MIT License
933 stars 229 forks source link

rename Tagging module? #24

Open goodwill opened 14 years ago

goodwill commented 14 years ago

As I have just went thru a serious conflict between vestal_versions and acts_as_taggable_on module, I wonder if there is a way to restructure the module locations to avoid such conflict.

henrypoydar commented 14 years ago

+1 ... I'm not using acts_as_taggable, just a hand-rolled tagging lib (thanks for this awesome gem, btw)

ericyoung commented 14 years ago

The tagging module also conflicts with is_taggable.

goodwill commented 14 years ago

Basically if the module can be stored inside something called VestalVersions::Extensions::Tagging, would that solve the problem? My bet is yes since its under another level of namespace, that way we could preserve the naming consistent while avoid the conflicts.

perueconomico commented 14 years ago

Maybe it can help: I get : Undefined method `reflect_on_association' for VestalVersions::Tagging:Module using ruby Enterprise 2009.10 and as taggable_on_steroids-1.2. and vestal_versions (1.0.2)

But in my Mac it works fine: ruby 1.8.7 (2008-05-31 patchlevel 0) [i686-darwin9.7.1] and acts_as_taggable_on_steroids (1.2) and using VestalVersion(0.8.3)

The diff: Version of VerstalVersion(0.8.3 vs 1.0.2). Something is broken in 1.0.2 I just upgraded the model with the migration in the Mac and I got the same error.

maduhaime commented 14 years ago

Same bug for me with... config.gem "acts-as-taggable-on", :version => '>=1.1.5', :source => '...' config.gem "vestal_versions", :version => '>=1.0.2'

maduhaime commented 14 years ago

Aslo, the tagging fonctionnality should be an optional feature... or can be rename to keywording

maduhaime commented 14 years ago

I have made a simple test by unzipping vestal_version in my vendor/plugins directory and do a massive search and replace for every reference to tag, tagging, tagged, etc. Guess what, it is working...

schlick commented 14 years ago

+1 I use acts_as_taggable_on and have encountered this problem. I modified acts_as_taggable_on in order to make it and Vestal work together.

bnferguson commented 14 years ago

+1, looks like http://github.com/dfurber/vestal_versions's fork is fixing the problem. Also would like the tagging module to be optional but that's something else.

kvnsmth commented 14 years ago

+1 This fork: http://github.com/rsim/vestal_versions fixes the problem and fixes the gemspec. Could this please be applied?

die-antwort commented 14 years ago

+1

bishopandco commented 14 years ago

I just branched and made a really cheep fix. http://github.com/theablefew/vestal_versions It just renames all tags to versionable_tags.

karlfreeman commented 13 years ago

+10, by the amount of forks fixing this one problem could this be rolled in? please? eg implement this https://github.com/andyverprauskus/vestal_versions/commit/1464eeeb10a8acf2854df5a8d7dd0f9ceb717766 totally still awesome just doesn't conflict :)

angelacode commented 13 years ago

I am still on 2.3.8 and using acts_as_taggable_on...which should I put in my Gemfile...? I am also currently getting the problem using a v 1.0.1 from laserlemon, thank you.

bishopandco commented 13 years ago

+10000