laserlemon / vestal_versions

Keep a DRY history of your ActiveRecord models' changes
MIT License
933 stars 229 forks source link

Fix for active_record-3.2.3 #83

Closed zhangyuan closed 11 years ago

zhangyuan commented 12 years ago

The current vestal_versions runs into some problems and warnings with active_record-3.2.3. Here are some fixes.

ActiveSupport::Deprecation.warn "The InstanceMethods module inside ActiveSupport::Concern will be no longer included automatically. Please define instance methods directly in #{self} instead."

By the way, rspec in Gemfile.lock is 2.1.0, which would not work well with Ruby-1.9.3. I've got the Error "run_hook_filtered': undefined methodrun_all' for []:Array". see also here: https://github.com/rspec/rspec-core/issues/248 . rspec >= 2.4.0 works well.

spheregenomics commented 12 years ago

Has this fix been merged?

dreamr commented 11 years ago

No longer needed, however, you should notice that table_name is a property now and needs to be set via =.

self.table_name = :users

dreamr commented 11 years ago

Thanks for your efforts! Greatly appreciated.